bugfix: extended locking duration for unlockUser test Locally, the lock duration was not long enough to last until the admin logged in to unlock them. This bypassed the need to interact with a dialog locally, and so the test was still succeeding even after an interaction command for this dialog was removed. This duration was long enough for the server however, and so the dialog demanding interaction would appear and crash the test. The expected lock duration has been extended by trigger +1 failed login attempts as well as the dialog interact.

Sohaib Baig commited 2025-11-26 16:05:44 +0100 commit c11a11341294611a02e0d25fcd0bbd140074ff06

				java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/adminconsole/usermanagement/UserManagementPanelPO.java
			
          @@ -187,6 +187,9 @@ public class UserManagementPanelPO extends PageArea {

                       final WebElement action = ActionsHelper.findUnlockAction(entry.getWebElement());

                       action.click();

                   }

          +        waitUntilAlertIsPresent();

          +        driver.switchTo().alert().accept();

          +        waitForAjaxRequests();

               }

               public void waitUntilUserFound(String userName) {

				java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/test/adminconsole/usermanagement/TestUserManagement.java
			
          @@ -110,7 +110,7 @@ public class TestUserManagement extends AbstractSeleniumTest {

                   createUser(userManagementPanel);

                   // logout so test user can login

                   AuthenticationMenuPO authenticationMenu = logoutAndGoToAdminConsolePage().getAuthenticationMenu();

          -        attemptAbusiveLogins(TEST_USER_NAME, "wrongPassword", 5, authenticationMenu);

          +        attemptAbusiveLogins(TEST_USER_NAME, "wrongPassword", 6, authenticationMenu);

                   // 16s lock window in place now, sufficient to log into admin, unlock user

                   // and return till test user can login, within the erstwhile lock window

                   assertTrue(authenticationMenu.attemptLogin("admin", "admin"));

...	...	@@ -187,6 +187,9 @@ public class UserManagementPanelPO extends PageArea {
187	187	final WebElement action = ActionsHelper.findUnlockAction(entry.getWebElement());
188	188	action.click();
189	189	}
	190	+ waitUntilAlertIsPresent();
	191	+ driver.switchTo().alert().accept();
	192	+ waitForAjaxRequests();
190	193	}
191	194
192	195	public void waitUntilUserFound(String userName) {

...	...	@@ -110,7 +110,7 @@ public class TestUserManagement extends AbstractSeleniumTest {
110	110	createUser(userManagementPanel);
111	111	// logout so test user can login
112	112	AuthenticationMenuPO authenticationMenu = logoutAndGoToAdminConsolePage().getAuthenticationMenu();
113		- attemptAbusiveLogins(TEST_USER_NAME, "wrongPassword", 5, authenticationMenu);
	113	+ attemptAbusiveLogins(TEST_USER_NAME, "wrongPassword", 6, authenticationMenu);
114	114	// 16s lock window in place now, sufficient to log into admin, unlock user
115	115	// and return till test user can login, within the erstwhile lock window
116	116	assertTrue(authenticationMenu.attemptLogin("admin", "admin"));