bug6232: added comment regarding instruction order in updateSettings

Axel Uhl commited 2026-04-10 01:03:08 +0200 commit 88f051aa78ba00c5f69eebda4a33778d529b29d3

				java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/leaderboard/SingleRaceLeaderboardPanel.java
			
          @@ -329,6 +329,8 @@ public class SingleRaceLeaderboardPanel extends LeaderboardPanel<SingleRaceLeade

               @Override

               public void updateSettings(SingleRaceLeaderboardSettings newSettings) {

          +        // Note: it's important to update showRaceRankColumn *before* calling super.updateSettings(newSettings)

          +        // because the base class implementation then also ensures all columns are displayed according to settings 

                   showRaceRankColumn = newSettings.isShowRaceRankColumn();

                   super.updateSettings(newSettings);

               }

...	...	@@ -329,6 +329,8 @@ public class SingleRaceLeaderboardPanel extends LeaderboardPanel<SingleRaceLeade
329	329
330	330	@Override
331	331	public void updateSettings(SingleRaceLeaderboardSettings newSettings) {
	332	+ // Note: it's important to update showRaceRankColumn before calling super.updateSettings(newSettings)
	333	+ // because the base class implementation then also ensures all columns are displayed according to settings
332	334	showRaceRankColumn = newSettings.isShowRaceRankColumn();
333	335	super.updateSettings(newSettings);
334	336	}