fix ip blocklist crashing LocalServer panel in the IP Blocklist panel, the unlock button was added at an index position. this was not necessary, but cascaded the issue that when the refresh button was not added at 0, inserting at index 1 caused errors cascading upto LocalServer. the refresh button did not need to be added before the commit separately because it was composed by a buttonPanel.addAction method that did both object creation and addition to the panel together before commit c10f6027a38f554a7227b2772c9ec809a341bc4c, and after that commit was created by a Button constructor.

Sohaib Baig commited 2025-11-07 11:18:56 +0100 commit 2ea8fa37ebef50ec53b49d0293d4c3a6b69a3689

				java/com.sap.sailing.gwt.ui/src/main/java/com/sap/sailing/gwt/ui/adminconsole/IPBlocklistTableWrapper.java
			
          @@ -103,13 +103,15 @@ abstract class IPBlocklistTableWrapper

               private Widget composeButtonPanel() {

                   final HorizontalPanel buttonPanel = new HorizontalPanel();

          -        final Button refreshbutton = new Button(getStringMessages().refresh(), new ClickHandler() {

          +        buttonPanel.setSpacing(5);

          +        final Button refreshButton = new Button(getStringMessages().refresh(), new ClickHandler() {

                       @Override

                       public void onClick(ClickEvent event) {

                           loadDataAndPopulateTable();

                       }

                   });

          -        refreshbutton.ensureDebugId("refreshButton");

          +        refreshButton.ensureDebugId("refreshButton");

          +        buttonPanel.add(refreshButton);

                   if (canUnlock()) {

                       final Button unlockButton = new SelectedElementsCountingButton<IpToTimedLockDTO>(

                               getStringMessages().unlock(), getSelectionModel(), new ClickHandler() {

          @@ -131,7 +133,7 @@ abstract class IPBlocklistTableWrapper

                                   }

                               });

                       unlockButton.ensureDebugId("unlockButton");

          -            buttonPanel.insert(unlockButton, 1);

          +            buttonPanel.add(unlockButton);

                   }

                   return buttonPanel;

               }

...	...	@@ -103,13 +103,15 @@ abstract class IPBlocklistTableWrapper
103	103
104	104	private Widget composeButtonPanel() {
105	105	final HorizontalPanel buttonPanel = new HorizontalPanel();
106		- final Button refreshbutton = new Button(getStringMessages().refresh(), new ClickHandler() {
	106	+ buttonPanel.setSpacing(5);
	107	+ final Button refreshButton = new Button(getStringMessages().refresh(), new ClickHandler() {
107	108	@Override
108	109	public void onClick(ClickEvent event) {
109	110	loadDataAndPopulateTable();
110	111	}
111	112	});
112		- refreshbutton.ensureDebugId("refreshButton");
	113	+ refreshButton.ensureDebugId("refreshButton");
	114	+ buttonPanel.add(refreshButton);
113	115	if (canUnlock()) {
114	116	final Button unlockButton = new SelectedElementsCountingButton<IpToTimedLockDTO>(
115	117	getStringMessages().unlock(), getSelectionModel(), new ClickHandler() {
...	...	@@ -131,7 +133,7 @@ abstract class IPBlocklistTableWrapper
131	133	}
132	134	});
133	135	unlockButton.ensureDebugId("unlockButton");
134		- buttonPanel.insert(unlockButton, 1);
	136	+ buttonPanel.add(unlockButton);
135	137	}
136	138	return buttonPanel;
137	139	}